chore(sdk): Add blanket impls for refs to prim traits #12613
Merged
+57
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
Rjected,
joshieDo,
rakita,
mattsse and
gakonst
as code owners
emhane
force-pushed
the
emhane/auto-impl-prims
branch
from
09d9df8 to
af2b8ff
Compare
3 tasks
emhane
commented
Nov 17, 2024
| @@ -32,7 +33,7 @@ pub trait SignedTransaction: | |||
| + alloy_rlp::Decodable | |||
| + Encodable2718 | |||
| + Decodable2718 | |||
| + TransactionExt | |||
There was a problem hiding this comment.
since trait TransactionExt shrunk to basically only this method which isn't called on TransactionSigned, its redundant as super trait
mattsse
approved these changes
Nov 17, 2024
Comment on lines
+34
to
+35
| /// Extension if [`Receipt`] used in block execution. | ||
| pub trait ReceiptExt: Receipt { |
There was a problem hiding this comment.
cool, splitting this makes sense we definitely want this because op can't have this
There was a problem hiding this comment.
ah true, optimism needs the chain spec too! in general, I'm not convinced that this is the right place for the method...think this approach made the most sense #11314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of places in the code take references to the primitive data types. For components to use these as generics, blanket impls of the data primitive traits for reference types, are needed.