Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): integrate generic receipt into execution #12397

Closed
wants to merge 111 commits into from
Closed

chore(sdk): integrate generic receipt into execution #12397

wants to merge 111 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 8, 2024 •
edited
Loading

Based on #12647

Ref #12358

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 8, 2024
@emhane emhane force-pushed the emhane/integrate-generic-receipt-execution branch from 2c4f8f3 to 05d2941 Compare November 10, 2024 13:18
@emhane emhane changed the base branch from main to emhane/node-prims-block-parts November 19, 2024 13:17
@fgimenez fgimenez mentioned this pull request Nov 19, 2024
Closed
1 task
emhane added 21 commits November 19, 2024 19:06
@emhane
Link FullNodePrimitives::BlockBody and FullNodePrimitives::BlockHeader
48b1ab3
@emhane
Merge branch 'main' into emhane/node-prims-block-parts
a1458ef
@emhane
Fix merge conflicts
bac2f0b
@emhane
Fix merge conflicts op
47badb2
@emhane
Remove Compact trait bound on FullSignedTx in accordance with Transac…
faa86ae 
…tionSigned
@emhane
Fix merge conflicts by introducing helper triat MaybeCompact
f65fb6d
@emhane
Define helper triat MaybeCompact
16b2caa
@emhane
Fix docs
f1689e5
@emhane
Merge branch 'emhane/maybe-compact' into emhane/node-prims-block-parts
dfd285f
@emhane
Fix docs
a35d1bb
@emhane
Merge branch 'emhane/maybe-compact' into emhane/node-prims-block-parts
f6ccb05
@emhane
Add no_std support for reth-optimism-primitives
bb6c040
@emhane
Fix deps
abd6bdc
@emhane
Fix deps
55c6f3c
@emhane
Fix deps
350974f
@emhane
Fix deps
1dd5939
@emhane
Merge branch 'main' into emhane/maybe-compact
9c63528
@emhane
Shrink scope
8a46085
@emhane
Merge branch 'emhane/maybe-compact' into emhane/node-prims-block-parts
164c694
@emhane
Fix conflicts
10adffa
@emhane
Merge branch 'emhane/node-prims-block-parts' into emhane/integrate-ge…
8399488 
…neric-receipt-execution
Base automatically changed from emhane/node-prims-block-parts to main November 21, 2024 17:18
@emhane
Copy link
Member Author

emhane commented Nov 25, 2024

doesn't make sense to continue fixing these merge conflicts, cc @Rjected @mattsse

@emhane emhane closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emhane @mattsse @klkvr @fgimenez