feat: track buffered outgoing messages #12220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caglaryucekaya
requested review from
emhane,
mattsse and
Rjected
as code owners
mattsse
requested changes
Oct 31, 2024
Comment on lines
772
to
777
| pub fn push_back(&mut self, message: OutgoingMessage) { | ||
| self.messages.push_back(message); | ||
| self.count.increment(1); | ||
| } | ||
|
|
||
| pub fn pop_front(&mut self) -> Option<OutgoingMessage> { |
There was a problem hiding this comment.
we can also make this pub crate
Comment on lines
778
to
781
| let message = self.messages.pop_front(); | ||
| if message.is_some() { | ||
| self.count.decrement(1); | ||
| } |
There was a problem hiding this comment.
we can solve this with Option::inspect
Comment on lines
+762
to
+765
| pub(crate) struct QueuedOutgoingMessages { | ||
| messages: VecDeque<OutgoingMessage>, | ||
| count: Gauge, | ||
| } |
There was a problem hiding this comment.
this could use a one line doc
|
|
||
| pub(crate) struct QueuedOutgoingMessages { | ||
| messages: VecDeque<OutgoingMessage>, | ||
| count: Gauge, |
There was a problem hiding this comment.
looking at the ordering in Gaugefn impl for Atomic I believe this should work and not result in overflows
mattsse
added
the
A-observability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12203