Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move FillTxEnv::fill_tx_env into SignedTransaction trait and implement in TransactionSigned #12186

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

garwahl
Copy link
Contributor

@garwahl garwahl commented Oct 30, 2024

Closes #12182

Moves fill_tx_env into the SignedTransaction trait and implements it in TransactionSigned

Comment on lines +1131 to +1134
/// Transaction
pub const fn transaction(&self) -> &Transaction {
&self.transaction
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume this is okay as we already have one for hash and signature. Need it below in the impl SignedTransaction

@garwahl
Copy link
Contributor Author

garwahl commented Oct 30, 2024

cc @emhane PTAL when you get the chance

Self::from_transaction_and_signature(transaction, signature)
}

fn fill_tx_env(&self, tx_env: &mut TxEnv, sender: Address) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't copy across anything flagged behind #[cfg(feature = "optimism")] as I assume that will go into OpTransactionSigned

@emhane
Copy link
Member

emhane commented Oct 30, 2024

I have a pr ready that I can stack right on top of this when merged, for removing op code from the rest of SignedTransaction impl

@emhane emhane enabled auto-merge November 4, 2024 06:42
@emhane emhane added this pull request to the merge queue Nov 4, 2024
Merged via the queue into paradigmxyz:main with commit bb03578 Nov 4, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy FillTxEnv::fill_tx_env into SignedTransaction trait
2 participants