chore: rm optimism feature from chainspec #11722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
fgimenez,
emhane,
rkrasiuk,
joshieDo and
gakonst
as code owners
mattsse
added
C-debt
emhane
approved these changes
Oct 15, 2024
| @@ -462,8 +462,7 @@ where | |||
| ) -> bool { | |||
| // On Optimism, the proposers are allowed to reorg their own chain at will. | |||
| #[cfg(feature = "optimism")] | |||
| if reth_chainspec::EthChainSpec::chain(self.blockchain.chain_spec().as_ref()).is_optimism() | |||
| { | |||
| if reth_chainspec::EthChainSpec::is_optimism(&self.blockchain.chain_spec()) { | |||
There was a problem hiding this comment.
we should open an issue to move away from this type of behaviour, since it requires every rollup to add a new is_my_rollup trait method to EthChainSpec, and instead solve it at sdk level for engine
There was a problem hiding this comment.
this crate will be deprecated soon, so no need to change anything here
Comment on lines
-58
to
-76
| impl<N> OpEthApi<N> | ||
| where | ||
| N: FullNodeComponents<Types: NodeTypes<ChainSpec = ChainSpec>>, | ||
| { | ||
| /// Builds a receipt w.r.t. chain spec. | ||
| pub fn build_op_receipt_meta( | ||
| &self, | ||
| tx: &TransactionSigned, | ||
| l1_block_info: revm::L1BlockInfo, | ||
| receipt: &Receipt, | ||
| ) -> Result<OpTransactionReceiptFields, OpEthApiError> { | ||
| Ok(OpReceiptFieldsBuilder::default() | ||
| .l1_block_info(&self.inner.provider().chain_spec(), tx, l1_block_info)? | ||
| .deposit_nonce(receipt.deposit_nonce) | ||
| .deposit_version(receipt.deposit_receipt_version) | ||
| .build()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
out of scope to remove unused code, but ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8904
we can finally do this, has no impact on any usage in beacon-consensus because we already use the proper OpChainSpec type everywhere