Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a new method to network config builder #11569

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: adding a new method to network config builder #11569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4add44
feat: adding a new method to network config builder
loocapro Oct 8, 2024
b614977
feat: also added listener port
loocapro Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/exex/test-utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ pub async fn test_exex_context_with_chain_spec(

let network_manager = NetworkManager::new(
NetworkConfigBuilder::new(SecretKey::new(&mut rand::thread_rng()))
.with_unused_discovery_port()
.build(provider_factory.clone()),
)
.await?;
Expand Down
12 changes: 12 additions & 0 deletions crates/net/network/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,18 @@ impl NetworkConfigBuilder {
self
}

/// Sets the discovery port to an unused port.
/// This is useful for testing.
pub fn with_unused_discovery_port(self) -> Self {
self.discovery_port(0)
}

/// Sets the listener port to an unused port.
/// This is useful for testing.
pub fn with_unused_listener_port(self) -> Self {
self.listener_port(0)
}

/// Sets the external ip resolver to use for discovery v4.
///
/// If no [`Discv4ConfigBuilder`] is set via [`Self::discovery`], this will create a new one.
Expand Down
Loading