-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): SignedTransaction
abstraction
#11432
Conversation
a26253c
to
d28569f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I really don't want to define new rlp functions on transaction trait now that we almost entirely on De/Encodable2718
could we start with something basic like Transaction: Encodable2718 + Decodeable2718
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we def need this trait, but this should be moved to the traits crate.
and we should try without introducing new rlp functions, we should manage without and instead require that this type is also De/Encodeable2718
pr doesn't introduce any new methods at all. method deprecated in #11218 is removed in commit b820aa8. |
cf72724
to
00f899f
Compare
re-request review @mattsse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this already does too much.
I'd like to start very simple with a very simplistic trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, lgtm!
Closes #11253
Checks out the abstraction of
TransactionSigned
from #11348 and #11352