Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exex): send canonical notifications when head is provided #11280

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 27, 2024

Closes #11202
Closes #11261

@shekhirin shekhirin added C-enhancement New feature or request A-exex Execution Extensions labels Sep 27, 2024
@shekhirin shekhirin force-pushed the alexey/exex-notifications-canonical branch from 5d98f01 to 6602143 Compare September 27, 2024 11:02
@shekhirin shekhirin force-pushed the alexey/exex-notifications-canonical branch from 6602143 to 7fb3540 Compare September 27, 2024 11:02
@shekhirin shekhirin marked this pull request as ready for review September 27, 2024 13:08
@shekhirin shekhirin requested a review from onbjerg as a code owner September 27, 2024 13:08
@shekhirin shekhirin requested review from mattsse and joshieDo and removed request for onbjerg September 27, 2024 13:08
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the bool toggles look correct to me

@shekhirin shekhirin added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 27, 2024
@shekhirin shekhirin enabled auto-merge September 27, 2024 15:09
@shekhirin shekhirin added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit dbd9a2b Sep 27, 2024
35 checks passed
@shekhirin shekhirin deleted the alexey/exex-notifications-canonical branch September 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a read-only handle to the ExEx WAL Revert ExEx WAL in case it's ahead of the node
2 participants