Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move op storage tests into new crate reth-optimism-storage #11233

Merged
merged 2 commits into from
Sep 26, 2024
Merged

move op storage tests into new crate reth-optimism-storage #11233

merged 2 commits into from
Sep 26, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 26, 2024 •
edited by emhane
Loading

Closes #11172

mattsse
mattsse reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshieDo I believe we need this soon anyway so makes sense to introduce even if this currently only contains tests.

but not quite sure tbh

@joshieDo
Copy link
Collaborator

i'd say let's go with it for now

emhane
emhane approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, closes in the pr description makes sure GitHub automatically closes the pr when it's merged. ref doesn't closes it, so makes sense if this pr is a subtask, then it's also helpful to add the pr to the issue's task list.

@emhane emhane added this pull request to the merge queue Sep 26, 2024
@nkysg
Copy link
Contributor Author

nkysg commented Sep 26, 2024

got it.You have told me, i forget. thx.@emhane

Merged via the queue into paradigmxyz:main with commit 2e05ec0 Sep 26, 2024
36 checks passed
@nkysg nkysg deleted the op_crate_storage branch September 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@emhane emhane emhane approved these changes

@joshieDo joshieDo joshieDo approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move op storage tests into new crate reth-optimism-storage
4 participants
@nkysg @joshieDo @mattsse @emhane