feat: make NetworkConfigBuilder independent of concrete ChainSpec
#11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/network-chainspec
branch
from
96860e9 to
3847e43
Compare
joshieDo
reviewed
Sep 25, 2024
klkvr
force-pushed
the
klkvr/network-chainspec
branch
from
10b1da8 to
f89cefd
Compare
joshieDo
approved these changes
Sep 26, 2024
mattsse
approved these changes
Sep 26, 2024
| @@ -75,9 +75,9 @@ impl Status { | |||
| /// | |||
| /// Sets the `chain` and `genesis`, `blockhash`, and `forkid` fields based on the [`ChainSpec`] | |||
| /// and head. | |||
| pub fn spec_builder(spec: &ChainSpec, head: &Head) -> StatusBuilder { | |||
| pub fn spec_builder(spec: impl EthChainSpec + Hardforks, head: &Head) -> StatusBuilder { | |||
There was a problem hiding this comment.
style nit, can we convert this to a where clause
| #[non_exhaustive] | ||
| pub struct NoopBlockReader; | ||
| pub struct NoopBlockReader<ChainSpec> { |
There was a problem hiding this comment.
we need a generic on this anyway so this is okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
Hardforkstrait with helper methods to obtainfork_idused by networking types.NetworkConfigBuilderis changed to accept chainspec intobuildmethod