Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: rm useless alloy_rpc_types reexport #11098

Merged
merged 8 commits into from
Sep 22, 2024

Conversation

tcoratger
Copy link
Contributor

Related #11067

@joshieDo joshieDo added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation labels Sep 21, 2024
@emhane emhane added this pull request to the merge queue Sep 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 22, 2024
@mattsse
Copy link
Collaborator

mattsse commented Sep 22, 2024

you will keep getting a ton of conflicts if you try to do this concurrently ;)

@tcoratger
Copy link
Contributor Author

you will keep getting a ton of conflicts if you try to do this concurrently ;)

let us merge #11095 and I'll handle the conflicts here, no problem :)

@tcoratger
Copy link
Contributor Author

@mattsse I wanted to keep individual PRs for easier review, type by type, don't know if it was the best idea ahah

@emhane
Copy link
Member

emhane commented Sep 22, 2024

you will keep getting a ton of conflicts if you try to do this concurrently ;)

let us merge #11095 and I'll handle the conflicts here, no problem :)

imo, nicer to stack these types of prs onto each other so base branch automatically changes to main and no conflicts (usually)

@tcoratger
Copy link
Contributor Author

@emhane should be ok now fyi

@emhane emhane enabled auto-merge September 22, 2024 14:22
@emhane emhane added this pull request to the merge queue Sep 22, 2024
Merged via the queue into paradigmxyz:main with commit 159bf2c Sep 22, 2024
36 checks passed
0xForerunner pushed a commit to 0xForerunner/reth that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants