Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): prevent noisy canonical block debug logs #11061

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(tree): prevent noisy canonical block debug logs #11061

merged 1 commit into from
Sep 20, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 20, 2024

Since we now have Display impls for ChainEvent<BeaconConsensusEngineEvent>, we can use Display to prevent logging the entire sealed header or block in these events.

@Rjected Rjected added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels Sep 20, 2024
@onbjerg onbjerg enabled auto-merge September 20, 2024 00:43
@onbjerg onbjerg added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit ec56530 Sep 20, 2024
36 checks passed
@onbjerg onbjerg deleted the dan/fix-noisy-logs branch September 20, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @onbjerg