Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exex): do not advance backfill range twice #10942

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

shekhirin
Copy link
Collaborator

this.range.by_ref().take(this.batch_size) in fact advances the original iterator -.-

Will add tests in the subsequent PR, for now this fix works as expected.

Before

2024-09-16T19:56:55.256356Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=0 last=9999
2024-09-16T19:56:55.556711Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=20001 last=30000
2024-09-16T19:56:55.569177Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=40002 last=50001
2024-09-16T19:56:55.578051Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=60003 last=70002

After

2024-09-16T20:00:04.281247Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=0 last=9999
2024-09-16T20:00:04.618367Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=10000 last=19999
2024-09-16T20:00:04.630539Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=20000 last=29999
2024-09-16T20:00:04.648388Z  INFO exex{id="MyExEx"}: alex88_repro: Processing range of blocks first=30000 last=3999

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-exex Execution Extensions labels Sep 16, 2024
@shekhirin shekhirin requested a review from onbjerg as a code owner September 16, 2024 20:01
@shekhirin shekhirin added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 8b61b9b Sep 16, 2024
36 checks passed
@shekhirin shekhirin deleted the alexey/backfill-stream-range-advance branch September 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants