fix: include reverts in execution outcome when building payload #10837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
force-pushed
the
fgimenez/fix-latest-valid-hash
branch
3 times, most recently
from
481fabe to
1e17675
Compare
fgimenez
force-pushed
the
fgimenez/fix-latest-valid-hash
branch
from
1e17675 to
24a9caa
Compare
fgimenez
changed the title
fgimenez
requested review from
onbjerg,
gakonst,
DaniPopes,
mattsse and
Rjected
as code owners
onbjerg
added
C-bug
mattsse
approved these changes
Sep 12, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hive failures introduced in #10717, the execution outcome calculated during payload build and inserted later in the in-memory tree state was missing reverts.
Also updates hive expected failures to match the current state.