feat: expose ChainSpec metrics
#10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly useful to expose the chain's name.
plaflamme
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
onbjerg
requested changes
Sep 6, 2024
Comment on lines
+5
to
+6
| #[derive(Debug, Clone)] | ||
| pub struct ChainSpecInfo { |
There was a problem hiding this comment.
this should use reth-metrics-derive if possible
There was a problem hiding this comment.
Looked into this one and I don't think it's possible. The thing is that this is a "fake" metric where we create a gauge that is only used to set labels on it. The gauge itself is never used. It doesn't look like reth-metrics-derive supports this case.
mattsse
added
C-enhancement
onbjerg
approved these changes
Sep 6, 2024
Not sure why this assertion is failing. When running binary, the gauge is correctly registered and the metric correctly shows up when querying the endpoint. The `reth_version_info` gauge is also missing, so this isn't new. Probably caused by the testing infrastructure that's missing some component, not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
ChainSpecInfostruct that can be used to expose staticChainSpecmetrics. The primary goal of this is to add the chain's name to the Grafana dashboard, but potentially other labels derived fromChainSpeccould also be exported.