feat: remove constraint of concrete type AnyTransactionReceipt for EthApiTypes::NetworkType

[nkysg]

Ref #10632

[nkysg]

error[E0599]: the method `into_rpc` exists for struct `OtterscanApi<EthApi>`, but its trait bounds were not satisfied
    --> crates/rpc/rpc-builder/src/lib.rs:1122:82
     |
1122 |                         RethRpcModule::Ots => OtterscanApi::new(eth_api.clone()).into_rpc().into(),
     |                                                                                  ^^^^^^^^
     |
    ::: /Users/ysg/Github/reth/crates/rpc/rpc/src/otterscan.rs:33:1
     |
33   | pub struct OtterscanApi<Eth> {
     | ---------------------------- doesn't satisfy 5 bounds
     |
     = note: the following trait bounds were not satisfied:
             `OtterscanApi<EthApi>: EthApiTypes`
             which is required by `OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `OtterscanApi<EthApi>: FullEthApi`
             which is required by `OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `<OtterscanApi<EthApi> as EthApiTypes>::NetworkTypes = _`
             which is required by `OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `<<EthApi as EthApiTypes>::NetworkTypes as Network>::ReceiptResponse = WithOtherFields<TransactionReceipt<AnyReceiptEnvelope<reth_rpc_types::Log>>>`
             which is required by `OtterscanApi<EthApi>: reth_rpc_api::OtterscanServer`
             `&OtterscanApi<EthApi>: EthApiTypes`
             which is required by `&OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `&OtterscanApi<EthApi>: FullEthApi`
             which is required by `&OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `<&OtterscanApi<EthApi> as EthApiTypes>::NetworkTypes = _`
             which is required by `&OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `&mut OtterscanApi<EthApi>: EthApiTypes`
             which is required by `&mut OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `&mut OtterscanApi<EthApi>: FullEthApi`
             which is required by `&mut OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`
             `<&mut OtterscanApi<EthApi> as EthApiTypes>::NetworkTypes = _`
             which is required by `&mut OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `reth-rpc-builder` (lib) due to 1 previous error

need to fix build error

[nkysg]

@emhane I don't know how to address this. the error info #10693 (comment)

[nkysg]

@emhane, sorry for that, I use force push.I just want to re implement.

[emhane]

 pub struct OtterscanApi<Eth> {
     | ---------------------------- doesn't satisfy 5 bounds
     |
     = note: the following trait bounds were not satisfied:
             `reth_rpc::OtterscanApi<EthApi>: reth_rpc_eth_api::EthApiTypes`
             which is required by `reth_rpc::OtterscanApi<EthApi>: reth_rpc_api::EthApiServer<_, reth_rpc_types::Block<_, _>, _>`

this is requiring that OtterscanApi be implemented for EthApiTypes with the concrete receipt type.AnyTransactionReceipt, otherwise EthApiServer isn't implemented for OtterscanApi. this is since the blanket implementation of EthApiServer requires that EthApiServer and EthApiTypes use the same receipt type.

receipt type taken from T which impl FullEthApi

reth/crates/rpc/rpc-eth-api/src/core.rs

Lines 365 to 372 in b0fddef

	impl<T>
	EthApiServer<
	RpcTransaction<T::NetworkTypes>,
	RpcBlock<T::NetworkTypes>,
	RpcReceipt<T::NetworkTypes>,
	> for T
	where
	T: FullEthApi,

EthApiTypes is a super trait of FullEthApi

reth/crates/rpc/rpc-eth-api/src/helpers/mod.rs

Lines 52 to 56 in b0fddef

	/// Helper trait to unify all `eth` rpc server building block traits, for simplicity.
	///
	/// This trait is automatically implemented for any type that implements all the `Eth` traits.
	pub trait FullEthApi:
	EthApiTypes

[emhane]

@emhane, sorry for that, I use force push.I just want to re implement.

alright then you saw commit 128802c?

[emhane]

leave concrete types for transaction and block for now everywhere, only relax the constraint on receipt. so we want

 EthApi: EthApiServer<
            reth_rpc_types::Transaction,
            reth_rpc_types::Block,
            RpcReceipt<EthApi::NetworkTypes>,
        >,

[nkysg]

Got it. I will address this.

[nkysg]

@emhane, sorry for that, I use force push.I just want to re implement.

alright then you saw commit 128802c?

got it.

[emhane]

blocked by alloy-rs/alloy#1245

[emhane]

this is the opposite of what we want, we want to remove this constraint. however, the possibility of doing so depends partly on alloy-rs/alloy#1245.

[emhane]

this constraint can now be removed since alloy-rs/alloy#1245 is closed. the new trait methods on alloy_network_primitives::ReceiptResponse should be enough to access fields on the receipt throughout this OtterscanServer impl.

[emhane]

this is one of prs that is also needed to unblock replacing AnyTransactionReceipt with RpcReceipt<Self::NetworkTypes> in EthApi trait methods #10781 @nkysg

[nkysg]

Thanks. Got it.

[emhane]

you know what, a better approach here is to change the description to "Ref <issue>" instead of "Closes <issue>", and merge this PR :)

[nkysg]

Thanks for correcting me. I saw many guys use closes, so I think it's right. I have modified it.

[emhane]

Thanks for correcting me. I saw many guys use closes, so I think it's right. I have modified it.

no worries, close is for when the issue is solved, and ref when it is related e.g. partly solves the issue