node: revise NodeTypes trait
#10665
Merged
node: revise NodeTypes trait
#10665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
mattsse,
Rjected,
fgimenez,
emhane,
onbjerg,
shekhirin and
gakonst
as code owners
mattsse
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
I assume we can relax some restrictions here if we split the PayloadTypes from the EngineTypes and also use this on NodeTypes, will investigate this separately.
There was a problem hiding this comment.
Yeah I assume that some NodeTypesWithEngine can become NodeTypes if they don't need engine. But certainly we can do it in a follow up PR to avoid too many changes at once.
joshieDo
approved these changes
Sep 3, 2024
klkvr
approved these changes
Sep 3, 2024
mattsse
added
S-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #9555