-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expose PruneConfig in CLI args #10639
chore: expose PruneConfig in CLI args #10639
Conversation
I'd say, any more specific flags than
lgtm
|
cc @emhane This is ready for review now PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
@emhane do you mind kicking off another run of the pipeline, lint should be fixed now. Thanks! |
remaining are lint fixes |
Hey @emhane could you kick off the lint again? I've run both |
@emhane do you mind running the lint on this PR and pushing to the branch, I've run |
I was struggling with the book too, removing this extension in VS code solved it for me. this extension was recommended by vs code, hence why I installed it in the first place. |
🤔 I'm running RustRover as an IDE. I'd be very surprised if the dev env impacts |
Could you sanity check and rebuild the book from this branch and see if you get the diff? I can't see why the IDE would impact it |
This PR closes #9816 and addresses #9808
This PR exposes
PruneConfig
via the CLI so that users can adjust any pruning configuration, similar to how it is adjusted inreth.toml
currently.cc @emhane