Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no feature gated imports #10440

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: no feature gated imports #10440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/rpc/rpc-eth-types/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ use reth_transaction_pool::error::{
PoolTransactionError,
};
use revm::primitives::{EVMError, ExecutionResult, HaltReason, OutOfGasError};
#[cfg(feature = "js-tracer")]
use revm_inspectors::tracing::js::JsInspectorError;
use revm_inspectors::tracing::MuxError;
use tracing::error;

Expand Down Expand Up @@ -194,10 +192,12 @@ impl From<EthApiError> for jsonrpsee_types::error::ErrorObject<'static> {
}

#[cfg(feature = "js-tracer")]
impl From<JsInspectorError> for EthApiError {
fn from(error: JsInspectorError) -> Self {
impl From<revm_inspectors::tracing::js::JsInspectorError> for EthApiError {
fn from(error: revm_inspectors::tracing::js::JsInspectorError) -> Self {
match error {
err @ JsInspectorError::JsError(_) => Self::InternalJsTracerError(err.to_string()),
err @ revm_inspectors::tracing::js::JsInspectorError::JsError(_) => {
Self::InternalJsTracerError(err.to_string())
}
err => Self::InvalidParams(err.to_string()),
}
}
Expand Down
Loading