fix: start payload builder on already canon head #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
mattsse
requested changes
Aug 2, 2024
mattsse
reviewed
Aug 2, 2024
crates/engine/tree/Cargo.toml
Outdated
Comment on lines
88
to
92
| optimism = [ | ||
| "reth-primitives/optimism", | ||
| "reth-provider/optimism", | ||
| "reth-revm/optimism" | ||
| ] |
There was a problem hiding this comment.
I really want to avoid this, why do we need this?
There was a problem hiding this comment.
optimism tests were stalling, let me double check that it wasn't just a flake
There was a problem hiding this comment.
ok, turns out it was just a flake, will file an issue for the flake and remove this
mattsse
reviewed
Aug 2, 2024
mattsse
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was stopping basically all hive tests, we still need to start a payload build process if the head is already canonical. In this case we also have to look up the canonical header.