Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optimism binary in optimism-cli #9408

Closed
Tracked by #7576
, #8988
...
mattsse opened this issue Jul 9, 2024 · 1 comment · Fixed by #9439
Closed
Tracked by #7576
, #8988
...

add optimism binary in optimism-cli #9408

mattsse opened this issue Jul 9, 2024 · 1 comment · Fixed by #9439
Assignees
@loocapro
Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 9, 2024 •
edited
Loading

blocked by #9407

move optimism binary to optimism-cli

reth/bin/reth/src/optimism.rs

Lines 16 to 17 in 7dab636

#[cfg(feature = "optimism")]
fn main() {

and then from reth-bin
@mattsse mattsse mentioned this issue Jul 9, 2024
Closed
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth labels Jul 9, 2024
@mattsse mattsse mentioned this issue Jul 9, 2024
Closed
@loocapro
Copy link
Contributor

May I?

@loocapro loocapro mentioned this issue Jul 11, 2024
Merged
@emhane emhane mentioned this issue Jul 13, 2024
Closed
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loocapro loocapro

Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving Optimism bin to Optimism Cli loocapro/reth
2 participants
@loocapro @mattsse