Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimism CLI type #9407

Closed
Tracked by #7576
mattsse opened this issue Jul 9, 2024 · 2 comments · Fixed by #9416
Closed
Tracked by #7576

add optimism CLI type #9407

mattsse opened this issue Jul 9, 2024 · 2 comments · Fixed by #9416
Assignees
Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 9, 2024

it's not reasonable to make the top level cli struct reusable, hence we should roll a standalone struct Cli for optimism that mimics the current one:

/// The main reth cli interface.
///
/// This is the entrypoint to the executable.
#[derive(Debug, Parser)]
#[command(author, version = SHORT_VERSION, long_version = LONG_VERSION, about = "Reth", long_about = None)]
pub struct Cli<Ext: clap::Args + fmt::Debug = NoArgs> {

this way we can get rid of all op specific commands and can select what commands we actually want for OP.

TODO

add op cli struct first

  1. duplicate Cli in optimism-cli crate

In followups we can define the op binary in optimism-bin

FYI @loocapro

@mattsse mattsse added A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth labels Jul 9, 2024
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Jul 9, 2024
@loocapro
Copy link
Contributor

loocapro commented Jul 9, 2024

May I get this?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 9, 2024

I think we should also move the Noargs type to reth-cli-commands first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants