-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example crate for custom rlpx subprotocol #7130
Comments
Hi @mattsse can I work on this? |
assigned, lmk if you need pointers/ have questions |
Thank you! Yeah, lol I need all the pointers I can get. You can give as many as you think will be useful. |
we want a new example crate, similar to this setup: reth/examples/custom-inspector/src/main.rs Lines 33 to 38 in 520d635
and after launch we inject a new rlpx protocol handler via the network the rlpx can be similar to the test example, could even be something like simple string message exchange |
Happy to take ownership of this issue |
@JackG-eth Please this is mine, working on it. |
@owanikin Hey, what's the status of this? Feel free to open a draft PR if you need feedback/direction or you are stuck :) |
@onbjerg I was stuck for a while :( .Kindly give me until the end of the week to make a PR. Thank you :) |
this shouldn't require any changes to the NodeHandle struct, instead the rlpx protocol can be installed via the NetworkHandle |
@loocapro are you going to take this? |
Yess! |
Describe the feature
Add a new example that showcases rlpx subprotocols, similar to this simple Ping/Pong protocol
reth/crates/net/network/tests/it/multiplex.rs
Lines 25 to 26 in c9c269b
but something more sophisticated
A protocol can be installed via:
reth/crates/net/network/src/network.rs
Lines 210 to 214 in c9c269b
Additional context
No response
The text was updated successfully, but these errors were encountered: