Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doesn't break prepared statements #208

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: doesn't break prepared statements #208

merged 1 commit into from
Feb 4, 2025

Conversation

rebasedming
Copy link
Contributor

Ticket(s) Closed

  • Closes #

What

Removes this unsafe hook that hijacked/broke prepare statements

Why

How

Tests

eeeebbbbrrrr
eeeebbbbrrrr approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code is the best code!

was there a reason for the specific handling of prepared statements that, now that we don’t do it, might cause some other problem with pg_analytics itself?

@rebasedming rebasedming merged commit 50fb17d into dev Feb 4, 2025
11 checks passed
@rebasedming rebasedming deleted the fix/prepare branch February 4, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeeebbbbrrrr eeeebbbbrrrr eeeebbbbrrrr approved these changes

@philippemnoel philippemnoel Awaiting requested review from philippemnoel philippemnoel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebasedming @eeeebbbbrrrr