-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mouse scrolling on topbar to scroll viewport #883
Conversation
I believe I've now fixed this. |
See #881. |
tested and it works, thank you! |
@Thesola10, can I get you to test this one out on a touchscreen? Now using |
panelbox). Changed `captured-event` to `touch-event` for touch based signals. Linter cleanup.
Seems however like the scroll handling is conflicting with vertical workspaces extensions such as V-Shell, just a heads-up (that would have been an approving review :p) |
Thanks @Thesola10. Hmm - I suppose we can make the topbar scroll handling an option (so users can disable it - if it messes with v-shell or other extensions). |
hmm... it might be that we're What are you seeing in V-Shell that's busted? (just so I can debug and check if the above fixes it). |
it seems both PaperWM and V-Shell try to handle the scroll wheel event, sometimes the PaperWM selection is moving but mostly V-Shell wins. Then again, maybe it's a Dash to Panel thing, but nothing is "broken" per se. |
hmm - seems v-shell is working fine for me. Will have a quick looksy at dash-to-panel. |
eh, either way it might be worth adding an option to disable the topbar scrolling. |
…nsions (#886) @Thesola10 mentioned some potential conflicts with the new mouse scrolling (on topbar) feature (#883) and other extensions (e.g. V-Shell and/or dash-to-panel). Small change in how PaperWM: propagate scroll-event signal after switching windows (in case other extensions require the event). Not sure if it will make a difference though.
Implements #206.
Allows switching windows with mouse scrolling on the gnome topbar.