Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now saving last window frame on layout. Using to restore original size from unmaximize #873

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Jun 8, 2024

This PR fixes an issue affecting some windows when using the new maxmize within tiling functionality by @valpackett.

Some application window weren't restoring to the size before the maximize-horizontally signal was received (e.g. code, brave weren't being restored for me).

This PR implements saving the last window size frame on layout call, which can then used to in unmaximizing a window before calling toggleMaximizeHorizontally.

@jtaala jtaala requested a review from valpackett June 8, 2024 10:59
@jtaala
Copy link
Collaborator Author

jtaala commented Jun 8, 2024

Hey @valpackett, could you please test these changes?

These changes fix an issues that affects some application windows.

Let me know if you run into any issues. I've disabled the layout call in the signal since layout will be called when the window is max'd / resized (from the resize handler). However, if doing another layout call afterwards helps with some some of those issues you mentioned in #870 please let me know (I couldn't reproduce any of them).

Thanks.

@jtaala jtaala changed the title Now saving last window frame on layout. Using to restore original size Now saving last window frame on layout. Using to restore original size from unmaximize Jun 8, 2024
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Jun 8, 2024
@jtaala jtaala linked an issue Jun 9, 2024 that may be closed by this pull request
@jtaala jtaala merged commit 16694bb into develop Jun 9, 2024
@jtaala jtaala deleted the fixes-maximize-within branch June 9, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximized windows are broken in weird ways
1 participant