-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ClickOverlay enterMonitor
reactive actor approach with much simpler implementation
#751
Conversation
with simple `PointerWatcher` approach. Repurpose ClickOverlay to only for for left/right stackoverlay (left/right window previews).
fe897a9
to
8b5b711
Compare
enterMonitor
reactive actor approach with much simpler implementation
okay, the touch workspace switching is working a lot better. No issues to report. Does not seem to impact #735 whatsoever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. To be honest it seems so simple compared to the click overlay...
I will use this for the next couple of days to see if I notice any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine. I didn't notice any problems.
I may have failed to properly test this PR. As it turns out, this seems to introduce a regression of #655. |
Thanks @Thesola10, My guess is that we may need to add a I've added this on PR #755 (see commit 21efa47). Note this may not do anything (and I don't have a touchscreen to test this on). Can you test 21efa47 and see if it responds to touch events on another monitor (it should activate that space on touch with this change). It may help in finding out more info here (or do nothing). |
This PR implements some fixes for a regression to touchscreen support by #751. It also includes some smaller fixes implemented during development of #755. Lastly, it includes replacing deprecated methods (which are entirely removed int Gnome 46). @Thesola10, can you give this branch a test and let me know if touch is working again?
@Lythenas, @Thesola10, I've been thinking about this one for a while:
PaperWM uses a very curious approach to implement a "one space per monitor" paradigm (see my response to a question of how PaperWM does this).
Unfortunately this approach is quite complex and exhibits many side-effects that have required many workarounds (which often causes further issues).
This PR replaces this approach with a simpler
PointerWatcher
implementation (a Gnome supported implementation to monitor mouse pointer movements). Moving to this approach provides the following advantages:Note: we actually already use the
PointerWatcher
approach for multi-monitor drag/drop support - so this PR is essentially removing the other approach and adding a "activate space" method to thePointerWatcher
.@Lythenas and @Thesola10 - could you give this PR branch a test? I'll set it as a draft atm given it's quite a large change and I'm sure there might be some side-effects from this.
@Thesola10 - I note that this may impact some of your touch signals, although, we no longer have the ClickOverlay element blocking actions so it may turn out better (just a hypothesis).