Fixes: keybind clash detection also correctly detects grave against mutter Above_Tab. Fix keybind replace.
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detection. Fix "a" (needs lowercase since reverse check is against lowercase "a".
jtaala
added
the
merging soon
|
Is it worth backporting this PR also to the gnome43 branch? |
recommended settings.
Most definitely! |
jtaala
removed
the
merging soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several keybind detection issues (one introduced in Gnome 44 support branch).
Keybind detection has been broken for a while - this became apparent in Gnome 44. Branch
fixes-gnome-44-supportfound and fixed the root cause of PaperWM not correctly identifying clashes with system keybinds (so that it can override them while PaperWM is active.FIX 1: mutter
Above_Tabcheck againstgraveMutter uses
Above_Tabin keybinds, while PaperWM and gnome can also usegrave, to describe the same button. This fix normalises these references in PaperWM keybind clashes so that clashes involving PaperWM vs. system keybinds involvinggraveare detected correctly (and overridden where needed).FIX 2:
Above_Tabinternal reference inadvertedly changed to uppercase infixes-gnome-44-supportbranchNot sure how (or why), but I changed the internal reference used by PaperWM to uppercase. This inadvertedly broke PaperWM keybind detection (in the PaperWM settings) involving
Above_Tab.