-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window touch drag-and-drop starts at pointer, not at finger #764
Comments
Any solution would require retrieving touch coordinates before a touch event is explicitly captured, just as Either we need to keep track of the global stage's last touch event (and while we're at it, develop a pointer broker between cursor and touch events), or a touch event context must be extracted from the window grab event... somehow... Line 66 in 35afc1a
Above is the exact line of code where touch-based coordinates are required but cannot be retrieved using touch events like below: Lines 88 to 95 in 35afc1a
|
This approach calls Utils.getPointerCoords() (the unified touch broker) when the event starts ONLY. Since the touch tracker fails to update once the event is "adopted" by a widget, we still need to update the global cursor's coordinates. This superficially fixes #764, but REVERT this commit before working on cleaning up touch handling!
This approach calls Utils.getPointerCoords() (the unified touch broker) when the event starts ONLY. Since the touch tracker fails to update once the event is "adopted" by a widget, we still need to update the global cursor's coordinates. This superficially fixes #764, but REVERT this commit before working on cleaning up touch handling!
Describe the bug
This is a technical addendum to #736. The way touch-based window dragging works, the initial coordinates when grabbing begins is used to determine the relative pointer position to the window using the global pointer. However, just as in #735, the global pointer cannot be used as a coordinates source for touch events.
This bug exists mainly as a self reminder, though anyone is free to pick it up.
To Reproduce
Expected behavior
Same behavior as mouse-based drag-and-drop
Screenshots
The window jumps relative to where the pointer was when the gesture started
System information:
Irrelevant -- trust me :)
The text was updated successfully, but these errors were encountered: