Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Martinh/remove goerli #68

Merged
merged 23 commits into from
Oct 24, 2024
Merged

Martinh/remove goerli #68

merged 23 commits into from
Oct 24, 2024

Conversation

martin0995
Copy link
Contributor

@martin0995 martin0995 commented Oct 15, 2024 •
edited
Loading

DESCRIPTION:

  • Ran npm run update and npm run generate
  • Removed Goerli from generation
  • Created Unichain file

albertov19 and others added 16 commits September 11, 2024 22:32
@albertov19
Merge pull request #22 from papermoonio/dev
1481acb 
Publish d30a0c
@eshaben
Merge pull request #27 from papermoonio/dev
b87dc1d 
publish e551c0 and styling changes
@eshaben
Merge pull request #30 from papermoonio/dev
1c0cb44 
publish 741eb2 and mkdocs configs for launch
@eshaben
Merge pull request #33 from papermoonio/dev
032c21c 
publish d945f6d (#32)
@albertov19
Merge pull request #39 from papermoonio/dev
4b7d187 
Publish aa94aad and minor edits before launch
@albertov19
Merge pull request #41 from papermoonio/dev
3c72d7a 
Publish ccd78607 and add CODEOWNERS
@albertov19
Merge pull request #45 from papermoonio/dev
a8b5ac2 
Update to bf4f760c and fix home page URLs
@albertov19
Merge pull request #47 from papermoonio/dev
d370055 
Publish a8971488
@eshaben
Merge pull request #49 from papermoonio/dev
ce974bb 
publish 70379eb (#48) to main
@albertov19
Merge pull request #52 from papermoonio/dev
f338f00 
Publish 5c679719
@eshaben
Merge pull request #54 from papermoonio/dev
692c63b 
Update mobile styling for chains list and publish d0462f
@albertov19
Merge pull request #56 from papermoonio/dev
7f716b2 
Publish 3b20cc35
@albertov19
Merge pull request #58 from papermoonio/dev
958ce94 
Add Pauline to CodeOwners and script to autogenerate chain info
@albertov19
Merge pull request #62 from papermoonio/dev
5a2b3da 
Publish 3297480, 6559091, and some other minor fixes
@eshaben
Merge pull request #67 from papermoonio/dev
a881c39 
publish b1915e
@martin0995
update and removed goerli from generation
4eacbaf
@martin0995 martin0995 added the enhancement New feature or request label Oct 15, 2024
@martin0995 martin0995 requested a review from eshaben October 15, 2024 18:18
eshaben
eshaben reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running npm run generate and it didn't remove the Goerli chains (i.e. Ethereum Goerli, Base Goerli). Did it automatically get rid of them for you?

@martin0995 martin0995 requested a review from eshaben October 22, 2024 15:50
eshaben
eshaben reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it again and now the script removes the Goerli testnet data, but it also removes the Arbitrum, Base, and Optimism mainnet data, but we want to keep that stuff

@martin0995 martin0995 requested a review from eshaben October 23, 2024 16:56
eshaben
eshaben reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Works like a charm now. Just noticed a couple small details to be cleaned up then it'll be good to gooooo 🚀

martin0995 and others added 3 commits October 24, 2024 11:57
@martin0995 martin0995 requested a review from eshaben October 24, 2024 09:58
eshaben
eshaben approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful - LGTM!

@eshaben eshaben merged commit 8d85624 into dev Oct 24, 2024
@eshaben eshaben deleted the martinh/remove-goerli branch October 24, 2024 14:51
@eshaben eshaben mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin0995 @eshaben @albertov19