Remove save_changes
#1130
Merged
Remove save_changes
#1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbeck
approved these changes
Aug 13, 2018
| If you want to selectively record changes for some models but not others you | ||
| can opt out of recording changes by passing `save_changes: false` to your | ||
| `has_paper_trail` method declaration. | ||
|
|
There was a problem hiding this comment.
Nice job getting the docs also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of #1099, followup to #1123.
This PR removes the
save_changesfeature in order to simplify the options provided to Paper Trail users. For those who need to save space, it's much more effective to remove the object column (introduced in #1123).