Fix saving changes on #touch #1084
Closed
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukayatsu
commented
May 14, 2018
| record = described_class.create(name: "Alice") | ||
| record.touch | ||
| expect(record.versions.last.reify.name).to eq("Alice") | ||
| end |
There was a problem hiding this comment.
On master branch, this spec passes on AR4.2 and AR5.0 but fails on AR5.1 and AR 5.2
Please see https://travis-ci.org/fukayatsu/paper_trail/builds/378643661 .
jaredbeck
added a commit
that referenced
this pull request
May 14, 2018
|
Thanks for the PR, Fukaya-san. The test you added is good. My only concern is the - r.paper_trail.record_update(force: true, in_after_callback: true)
+ r.paper_trail.record_update(force: true, in_after_callback: false)PT installs an First, I thought maybe we should change the name of the argument? But, it's not easy to come up with a better name. How about just passing another argument? - r.paper_trail.record_update(force: true, in_after_callback: true)
+ r.paper_trail.record_update(force: true, in_after_callback: true, is_touch: true)Please see #1085 |
|
@jaredbeck Thank you for the quick response. |
|
Fixed by #1085, released in 9.0.2. Thanks, Fukaya-san. |
aried3r
pushed a commit
to aried3r/paper_trail
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from: #1073 (comment)
Related to #1076