Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versions storing attributes as nil while manually creating a version #1048

Closed

Conversation

abhinav-shrivastava
Copy link

Fixes #1047

The @record.attribute_before_last_save(attr_name.to_s) is giving me nil but if I try @record.attribute_was('name') in my console it gives me the correct value of the record. Adding @record.attribute_in_database(attr_name.to_s) worked for me.

@jaredbeck
Copy link
Member

Hi Abhinav, thanks for the contribution.

  • Tests are failing.
  • Please add new test(s) for your changes.

@jaredbeck
Copy link
Member

Hi Abhinav, are you still working on this? Want me to keep it open?

@jaredbeck
Copy link
Member

This solution does pass the existing tests. Please:

Thanks!

@jaredbeck
Copy link
Member

Closing due to inactivity, and does not pass CI.

@jaredbeck
Copy link
Member

Fixed by #1060, will release as 9.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants