Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add missing types #284

Merged
merged 7 commits into from
Sep 2, 2020
Merged

fix(typescript): add missing types #284

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c4f446
fix: add missing types
jaulz Sep 1, 2020
d83295f
fix: add generic
jaulz Sep 1, 2020
49f7e99
fix: remove supported_scopes and add static issuer
jaulz Sep 1, 2020
bff397c
style: remove whitespaces
jaulz Sep 1, 2020
0c1c23e
fix: remove this in static property
jaulz Sep 1, 2020
3b40cb0
Apply suggestions from code review
panva Sep 2, 2020
cdea4ea
Apply suggestions from code review
panva Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ export interface ClientMetadata {
authorization_encrypted_response_alg?: string;
authorization_encrypted_response_enc?: string;
authorization_signed_response_alg?: string;

scopes_supported?: string[];

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes_supported is not an IANA registered client metadata property. Please remove this blob.

scopes_supported could potentially go to the IssuerMetadata interface, but as the library never reacts to its presence it's not included. I'm keen to only include properties that change the client/issuer behaviour. So it's either all or nothing and i think the inclusion of [key: string]: unknown; handles all possible metadata for anyone.

[key: string]: unknown;
}

Expand Down Expand Up @@ -346,6 +347,7 @@ export class Client {
[custom.http_options]: CustomHttpOptionsProvider;
[custom.clock_tolerance]: number;
metadata: ClientMetadata;
issuer: Issuer<this>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a static version of it, please add that too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


/**
* Returns the target authorization redirect URI to redirect End-Users to using the provided parameters.
Expand Down