Skip to content

Commit

Permalink
[pdata] Remove TODO, move to issue (open-telemetry#8977)
Browse files Browse the repository at this point in the history
**Description:** 

Removes `TODO` from code in favor of having this on the issue tracker as
we do for most issues.

**Link to tracking Issue:** This is now tracked by issue open-telemetry#8976
  • Loading branch information
mx-psi authored and pantuza committed Dec 8, 2023
1 parent 32b3c26 commit 3e15791
Show file tree
Hide file tree
Showing 19 changed files with 0 additions and 19 deletions.
1 change: 0 additions & 1 deletion pdata/internal/cmd/pdatagen/internal/base_slices.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ func (es {{ .structName }}) RemoveIf(f func({{ .elementName }}) bool) {
(*es.orig)[newLen] = (*es.orig)[i]
newLen++
}
// TODO: Prevent memory leak by erasing truncated values.
*es.orig = (*es.orig)[:newLen]
}
Expand Down
1 change: 0 additions & 1 deletion pdata/pcommon/slice.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ func (es Slice) RemoveIf(f func(Value) bool) {
(*es.getOrig())[newLen] = (*es.getOrig())[i]
newLen++
}
// TODO: Prevent memory leak by erasing truncated values.
*es.getOrig() = (*es.getOrig())[:newLen]
}

Expand Down
1 change: 0 additions & 1 deletion pdata/plog/generated_logrecordslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/plog/generated_resourcelogsslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/plog/generated_scopelogsslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_exemplarslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_histogramdatapointslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_metricslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_numberdatapointslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_resourcemetricsslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_scopemetricsslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/pmetric/generated_summarydatapointslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/ptrace/generated_resourcespansslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/ptrace/generated_scopespansslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/ptrace/generated_spaneventslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/ptrace/generated_spanlinkslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pdata/ptrace/generated_spanslice.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3e15791

Please sign in to comment.