Split client-related logic out of the PantsDaemon class #9949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/split-out-pantsd-client
branch
from
6f858e7 to
48969b1
Compare
…ent and PantsDaemonProcessManager. [ci skip-rust-tests] [ci skip-jvm-tests]
stuhood
force-pushed
the
stuhood/split-out-pantsd-client
branch
from
48969b1 to
7ee2cb6
Compare
gshuflin
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
PantsDaemonclass was playing double duty as both the entrypoint for the pantsd server, and as a launcher for the client. We will soon need to make significant changes there in order to support #8200 and #7654.Solution
Extract a
PantsDaemonProcessManagerbase class for process metadata reads/writes and aPantsDaemonClientsubclass to consume the metadata to decide whether to launch the server. This is 100% code moves... no logic changed.Result
The
PantsDaemonclass is now exclusively a server, andPantsDaemonClientis now exclusively a client.[ci skip-rust-tests]
[ci skip-jvm-tests]