Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[export-dep-as-jar] Include transitive target dependencies in export-dep-as-jar #9146

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

blorente
Copy link
Contributor

@blorente blorente commented Feb 18, 2020

Problem

There is currently no way for a tool consuming the output of export-dep-as-jar to know whether to traverse the transitive dependency graph of a target or not. The tool shouldn't do that when the target has strict_deps enabled.

Solution

Add a field to the ouput of the target, "source_dependencies_in_classpath". This field is the intersection between "modulizable targets" and "transitive dependencies", respecting strict_deps.

Result

The output for the target now has that field, called source_dependencies_in_classpath. Tools can use this field instead of targets when figuring out which targets need including in the classpath. No need to traverse targets now.

@blorente blorente force-pushed the blorente/fastpass/strict_deps branch 2 times, most recently from 8ceef67 to cb8b4c3 Compare February 19, 2020 13:12
@blorente blorente force-pushed the blorente/fastpass/strict_deps branch from cb8b4c3 to a4fb1cf Compare February 19, 2020 16:56
@blorente blorente merged commit b7aea0e into pantsbuild:master Feb 20, 2020
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants