[export-dep-as-jar] Include transitive target dependencies in export-dep-as-jar #9146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is currently no way for a tool consuming the output of
export-dep-as-jar
to know whether to traverse the transitive dependency graph of a target or not. The tool shouldn't do that when the target hasstrict_deps
enabled.Solution
Add a field to the ouput of the target, "source_dependencies_in_classpath". This field is the intersection between "modulizable targets" and "transitive dependencies", respecting
strict_deps
.Result
The output for the target now has that field, called
source_dependencies_in_classpath
. Tools can use this field instead oftargets
when figuring out which targets need including in the classpath. No need to traversetargets
now.libraries
field #9145