Only compile non-module exports for export-dep-as-jar goal
#8914
Conversation
|
@wisechengyi @blorente @stuhood (maybe) reviews please :) |
this is not technically feasible from v1 right now, because product required initialized before options and cannot be changed by options. However, we could still make a separate task for it. |
|
As a general comment, the
@wisechengyi : This isn't accurate I don't think? The |
|
Hey @olafurpg re:
This PR doesn't change how resources in target roots are packaged. Only whether the sources are compiled or not. Though looking at https://github.com/pantsbuild/pants/pull/8812/files#diff-fc0db43987b87bb51793c258ab96b407R347 from #8812 it seems like non-modulizable targets (which include target roots,) may not zip resources into jars because this line https://github.com/pantsbuild/pants/pull/8812/files#diff-fc0db43987b87bb51793c258ab96b407R301 is now in a separate function which isn't applied to all targets. |
tests/python/pants_test/backend/jvm/tasks/jvm_compile/test_jvm_compile.py
Outdated
Show resolved
Hide resolved
tests/python/pants_test/backend/jvm/tasks/jvm_compile/test_jvm_compile.py
Outdated
Show resolved
Hide resolved
stuhood
changed the title
export-dep-as-jar goal
| # so however we compute runtime_classpath it will contain all the nescessary jars for | ||
| # the export_dep_as_jar_classpath.export_dep_as_jar_classpath. | ||
| if self.context.products.is_required_data('export_dep_as_jar_classpath'): | ||
| self.context.products.get_data('export_dep_as_jar_classpath', classpath_product.copy) |
There was a problem hiding this comment.
It's fine for now, but get_data isn't guaranteed to have the sideeffect of calling the initializer: if you ever installed another task to compute additional entries for export_dep_as_jar_classpath and it ran first, this would break, because copy would not be called.
There was a problem hiding this comment.
Good to know for the future, thanks!
### Problem When running the `export-dep-as-jar` Goal we compile all targets in the build context. This is unnecessary and can be problematic if any of the target roots have compile errors in them, because the export will fail. It is unnecessary because the target roots are being exported as source modules #8812 ### Solution We exclude target_roots, and their dependees from the compile context. ### Result Only targets in the build context that are not being exported as sources are compiled.
Problem
When running the
export-dep-as-jarGoal we compile all targets in the build context. This is unnecessary and can be problematic if any of the target roots have compile errors in them, because the export will fail. It is unnecessary because the target roots are being exported as source modules #8812Solution
We exclude target_roots, and their dependees from the compile context.
Result
Only targets in the build context that are not being exported as sources are compiled.