Modify isort config to prepare for black formatting #8332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Sep 26, 2019
.isort.cfg
Outdated
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| [settings] | |||
| line_length=100 | |||
| multi_line_outddput=3 | |||
There was a problem hiding this comment.
This doesn't look like a valid setting?
There was a problem hiding this comment.
Correct, and that's why all these files are formatted wrong! https://github.com/psf/black#how-black-wraps-lines
jsirois
reviewed
Sep 26, 2019
.isort.cfg
Outdated
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| [settings] | |||
| line_length=100 | |||
| multi_line_outddput=3 | |||
There was a problem hiding this comment.
Correct, and that's why all these files are formatted wrong! https://github.com/psf/black#how-black-wraps-lines
pierrechevalier83
force-pushed
the
pchevalier/pre_black/isort
branch
from
6af958f to
34efe0a
Compare
jsirois
approved these changes
Sep 26, 2019
|
Note: this is one of the prerequisites for #8334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the formatting situation in the python code is quite painful as it involves manual formatting of code.
I would like to replace our current workflow with one involving Black in a subsequent PR (see motivations for the choice over there).
Black is opinionated about code layout, so with our current settings, Black and isort would be having minor opinion differences.
Solution
Modify the isort configuration to bend to Black's taste.
Result
Once we run Black on the codebase with a minimal configuration, isort will be happy with the results.