add a non-numeric prefix before the unstable package version to avoid truncation #7400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Mar 18, 2019
stuhood
approved these changes
Mar 18, 2019
|
It feels like it might be just as easy to tackle #7399 here as it is to add the A useful "date" slug to add might be something like: EDIT: Oooh, nevermind. I take that back. Adding the time prefix would require coordination between wheel shards. |
cosmicexplorer
force-pushed
the
fix-numeric-sha-prefix
branch
from
a40673b to
b6ef667
Compare
… parsed and truncated as a number
cosmicexplorer
force-pushed
the
fix-numeric-sha-prefix
branch
from
b6ef667 to
84b30a7
Compare
stuhood
pushed a commit
that referenced
this pull request
Mar 20, 2019
… parsed and truncated as a number (#7400) ### Problem See #7399. The commit 0672383 experienced CI failures, because our current method of generating the "unstable" pants version to build wheels puts the hexadecimal sha as its own version component: if the sha happens to be completely numeric and begins with any zeroes, `packaging.version.Version()` will helpfully truncate it -- but our `release.sh` script wasn't aware of that. ### Solution - Add a non-numeric prefix before the sha to generate `PANTS_UNSTABLE_VERSION` in `release.sh` to avoid possible truncation. - The prefix chosen was `git`. ### Result Commit shas starting with zero and containing only numbers for the first 8 characters will no longer fail in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #7399. The commit 0672383 experienced CI failures, because our current method of generating the "unstable" pants version to build wheels puts the hexadecimal sha as its own version component: if the sha happens to be completely numeric and begins with any zeroes,
packaging.version.Version()will helpfully truncate it -- but ourrelease.shscript wasn't aware of that.Solution
PANTS_UNSTABLE_VERSIONinrelease.shto avoid possible truncation.git.Result
Commit shas starting with zero and containing only numbers for the first 8 characters will no longer fail in CI.