Hotfix Python 2 regression from #7366 using FileNotFoundError #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Mar 14, 2019
tests/python/pants_test/backend/python/interpreter_selection_utils.py
Outdated
Show resolved
Hide resolved
Good suggestion Daniel!
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 18, 2019
Eric-Arellano
added a commit
that referenced
this pull request
Mar 18, 2019
…job (#7391) ### Problem The lint shard is a very cost-effective way to prevent Py2 regressions. For only about 8 minutes of extra total worker time, we can ensure we are always using defined symbols, for example. This would have prevented #7381 for example. In fact, that PR didn't even properly fix the issue. Running the lint shard during daily CI would have both prevented the issue in the first place and ensured the hotfix worked. ### Solution Run the lint shard with both Py2 and Py3 during daily CI. No longer run during nightly cron job. Also fix the issue #7381 was supposed to fix. ### Result We should have less Python 2 regressions. While CI will take 10 minutes longer of total worker time, the wall time should not be changed (beyond when we don't have enough workers). This extra time is worth the lowered risk of regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The function
python_interpreter_path()frominterpreter_selection_utils.pywas originally failing to execute on Py3 because it would encounterFileNotFoundError, which we weren't catching, so we added this to the except statement in #7366.However, the exception apparently does not exist in Python 2, so the nightly cron job failed: https://travis-ci.org/pantsbuild/pants/jobs/506186166#L952.
Solution
Alias the error
if PY2. We use this idiom, rather than a try except, so that we can easily automatically delete this code once we drop Py2.Result
PY=python2.7 ./build-support/bin/pre-commit.shnow works again.