Allow Rust to store unicode as well as bytes
#6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently unused, but will be used to land pantsbuild#6103 with DirectoryDigest.fingerprint being a `unicode` not a `bytes`.
|
Thanks Daniel! This patch works from the Python side of things. I changed DirectoryDigest to use unicode instead of bytes, and everything passes 🎉 Once this PR gets merged, I'll push the update to #6103. All the other PRs I have ready to go (about 10) are built on top of #6103, so both this PR and that will be blockers soon until they're merged. |
stuhood
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently unused, but will be used to land
#6103 with
DirectoryDigest.fingerprint being a
unicodenot abytes./cc @Eric-Arellano