Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rust 1.27 #6035

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Update to rust 1.27 #6035

merged 4 commits into from
Jun 27, 2018

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jun 27, 2018 •
edited
Loading

Let's try this again, but with more resolve!

Bump to rust 1.27, explicitly use Itertools::flatten, re-apply rustfmt, and bump the travis OSX image.

@stuhood
Copy link
Member Author

stuhood commented Jun 27, 2018

Individual commits should be useful for review.

IMO, although unfortunate, not being stuck on an older version of rust is worth dropping support for OSX < 10.11.

@stuhood stuhood mentioned this pull request Jun 27, 2018
Closed
kwlzn
kwlzn approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

illicitonion
illicitonion approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rust linux shard had a flaky failure; I re-ran it and it went green.

Thanks for pushing this!

@stuhood stuhood mentioned this pull request Jun 27, 2018
Merged
@stuhood stuhood merged commit 9be434e into pantsbuild:master Jun 27, 2018
@stuhood stuhood deleted the stuhood/rust-1.27 branch June 27, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsirois jsirois jsirois approved these changes

@illicitonion illicitonion illicitonion approved these changes

@kwlzn kwlzn kwlzn approved these changes

@dotordogh dotordogh Awaiting requested review from dotordogh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuhood @jsirois @illicitonion @kwlzn