Fix rpc style in compiler_args check. #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test to cover this. |
|
I also ran source sandbox which succeeds: source_sandbox_phab_production/4562/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While trying to test the pants build in source repo I realizes that the compiler_args_has_rpc_style is broken because the compiler args will have double dash in front e.g. --finagle whereas values in _RPC_STYLES don't. This results in scrooge generation failing if both compiler_args and rpc_style specify rpc style.
Solution
Fixed the check.
Result
Setting compiler args to --finagle in java_thrift_libraries pants targets now succeeds even if rpc_style is defined.