[engine] Minor perf: use _kwargs in Struct._key #4107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Struct._key is called ~460k times running list in the pants repo. The @Property machinery invoked for self.address ends up taking ~3-5% of time. Solution -------- Inline the _kwargs.get call for address in this specific case. Another more invasive solution would be to set __dict__ to _kwargs, but that would have other effects that we might not want.
kwlzn
approved these changes
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Struct._key is called ~460k times running list in the pants repo. The @Property machinery invoked for self.address ends up taking ~3-5% of time.
Solution
Inline the _kwargs.get call for address in this specific case.
Another more invasive solution would be to set dict to _kwargs, but that would have other effects that we might not want.