Task to gather local python sources into a pex. #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Nov 20, 2016
| round_manager.require_data(PythonInterpreter) | ||
|
|
||
| def execute(self): | ||
| targets = self.context.targets(lambda tgt: isinstance(tgt, PythonTarget) or |
There was a problem hiding this comment.
The isinstance(tgt, (PythonTarget, Resources)) form still fits in <100 cols and leverages the lib.
There was a problem hiding this comment.
Oh yeah! I forgot that was possible. Fixed.
| self.context.log.debug(' Dumping sources: {}'.format(tgt)) | ||
| for relpath in tgt.sources_relative_to_source_root(): | ||
| try: | ||
| copy_to_chroot(tgt.target_base, relpath, builder.add_source) |
There was a problem hiding this comment.
Perhaps just inline copy_to_chroot, its overly indirect since there is only ever builder.add_source passed as add_function for example.
There was a problem hiding this comment.
Good call. This was a leftover from the code I copied it from, which handled old-style resources using copy_to_chroot as well, and I didn't notice I could kill it. Done.
|
|
||
| if getattr(tgt, 'resources', None): | ||
| # No one should be on old-style resources any more. And if they are, | ||
| # switching to the new python pipeline will be a great opportunity to get fix that. |
There was a problem hiding this comment.
Verbage is off, probably just s/get fix/fix/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the new python pipeline.