Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python protobuf codegen export to coexist with namespace/host package (Cherry-pick of #21665) #21675

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

WorkerPants
Copy link
Member

Before this change, if a codegen export clashes with an existing package in the venv the export halts completely. The current change skips the problematic exports. This is sub optimal because not all symbols are exported but better than halting the export.

See #21659

…ackage (#21665)

Before this change, if a codegen export clashes with an existing package
in the venv the export halts completely. The current change skips the
problematic exports. This is sub optimal because not all symbols are
exported but better than halting the export.

See #21659
@huonw huonw requested a review from tgolsson November 25, 2024 23:18
@tgolsson tgolsson merged commit 602a8c6 into 2.24.x Nov 26, 2024
24 checks passed
@tgolsson tgolsson deleted the cherry-pick-21665-to-2.24.x branch November 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants