Prepare 2.24.0.dev0 #21412
Merged
Prepare 2.24.0.dev0 #21412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
added
automation:release-prep
This was referenced Sep 16, 2024
huonw
added a commit
that referenced
this pull request
Sep 16, 2024
This unblocks doing 2.24 dev releases while we get ourselves sorted and upgrade OSes on CI. Our current 2.23 builds are issuing the following warning, which becomes an error for 2.24-versioned builds (like #21412): ``` 14:44:14.41 [WARN] DEPRECATED: using Pants on macOS 10.15 - 11 is scheduled to be removed in version 2.24.0.dev0. Future versions of Pants will only run on macOS 12 and newer, but this machine appears older (macOS-10.15.7-x86_64-i386-64bit). You can temporarily silence this warning with the `[GLOBAL].allow_deprecated_macos_before_12` option. If you have questions or concerns about this, please reach out to us at https://www.pantsbuild.org/community/getting-help. ``` The underlying deprecation is that Pants 2.24..0.dev0 and newer will no longer support running of Pants on macOS < 12, and that includes our own in-repo builds. However, it's strictly more permissive to build on macOS 10.15 or 11, so we're "allowed" to do that even though it's after the deprecation time. Upgrading the runners properly is covered by #21413. The x86-64 change is in #21417.
huonw
added a commit
that referenced
this pull request
Sep 16, 2024
This `py_hermetic_scripts` option was deprecated in #21181 in favour of the new `py_non_hermetic_scripts_in_resolve` option. This was merged for 2.23.0.dev6 and thus will come in 2.23.0 soon-ish... It seems to be very little code to support `py_hermetic_scripts` (just a single extra clause in an `if` statement, plus the option definition itself), so it seems unnecessarily aggressive to deprecate in one cycle. This extends it a few releases to make it easier for users to test pre-releases. For instance, someone using 2.22.0 (current stable) with `py_hermetic_scripts` can currently test 2.23.0a0 with just a warning (e.g. adjust `pants_version` and run it through their CI), but would be blocked from doing _any_ testing of 2.24.0.dev0 (#21412) until they fix this option. That is, by removing the option quickly, it's harder for them to validate any part of the 2.24 or 2.25 release series and provide us feedback while on older versions. (We're being more permissive than what we were previosuly communicating, so I don't think we need release notes or to otherwise highlight it.)
tdyas
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.