Kill PANTS_VERBOSE and PANTS_BUILD_ROOT. #2129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PANTS_VERBOSE env var was obsolete and just needed a logger plumbed and the PANTS_BUILD_ROOT was unused and unuseable since code elsewhere in Config does `os.path.join(get_buildroot(), 'pants.ini')` which assumes no PANTS_BUILD_ROOT env var override took place (because the default way to establish the build root is in fact the inverse of the path join!). Docs and messages are all updated to kill mention of these 2 dead env vars and a few extra doc lies are removed or fixed.
|
This addresses #2118 |
|
Submitted @ 1a21814 |
Eric-Arellano
pushed a commit
that referenced
this pull request
Aug 16, 2020
https://github.com/pypa/setuptools/releases/tag/v49.6.0 https://github.com/pypa/setuptools/blob/master/CHANGES.rst * #2129: In pkg_resources, no longer detect any pathname ending in .egg as a Python egg. Now the path must be an unpacked egg or a zip file. * #2306: When running as a PEP 517 backend, setuptools does not try to install ``setup_requires`` itself. They are reported as build requirements for the frontend to install. * #2310: Updated vendored packaging version to 20.4. * #2300: Improve the ``safe_version`` function documentation * #2297: Once again, in stubs prefer exec_module to the deprecated load_module. * #2316: Removed warning when ``distutils`` is imported before ``setuptools`` when ``distutils`` replacement is not enabled. * #2259: Setuptools now provides a .pth file (except for editable installs of setuptools) to the target environment to ensure that when enabled, the setuptools-provided distutils is preferred before setuptools has been imported (and even if setuptools is never imported). Honors the SETUPTOOLS_USE_DISTUTILS environment variable. pypa/setuptools#2257: Fixed two flaws in distutils._msvccompiler.MSVCCompiler.spawn. instead of #10561 [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PANTS_VERBOSE env var was obsolete and just needed a logger plumbed
and the PANTS_BUILD_ROOT was unused and unuseable since code elsewhere
in Config does
os.path.join(get_buildroot(), 'pants.ini')whichassumes no PANTS_BUILD_ROOT env var override took place (because the
default way to establish the build root is in fact the inverse of the
path join!).
Docs and messages are all updated to kill mention of these 2 dead env
vars and a few extra doc lies are removed or fixed.
https://rbcommons.com/s/twitter/r/2760/