Run more rules concurrently when building a pex #20988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
force-pushed
the
huonw/concurrent-pex-build-setup
branch
from
9911670 to
b4bf53f
Compare
cognifloyd
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the setup rules invoked to build a pex to run concurrently where they can.
This probably doesn't make too much difference in the common case at the moment, since these seem to currently run very fast (for the single sample I did, of running
pants --no-local-cache test src/python/pants/backend/python/util_rules/pex_test.py), but:_setup_pex_requirementsstart invoking external processes (pex3 lock export-subset) for Pants triggering a rebuild even if dev-dependency updated #15694, which'll make it much more expensive.There's a few moving parts across separate individually-sensible commits. This includes switching to use call-by-name syntax as a bit of an experiment.
I've labelled this as category:internalCI, fixes for not-yet-released features, etc.
, not
category:performance
, because it doesn't seem like it has much impact at the moment.